Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for python 3.10 #18

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Remove support for python 3.10 #18

merged 2 commits into from
Jan 25, 2022
+353 −357

Conversation

mhiro2
Copy link
Collaborator

@mhiro2 mhiro2 commented Jan 25, 2022

WHY

Right now, python 3.10 is not supported by apache-beam (2.35.0) so we should remove it.
See also #8

WHAT

  • Remove python 3.10 in pyproject.toml
    • Specify the supported python versions more precisely in pyproject.toml.

@mhiro2 mhiro2 self-assigned this Jan 25, 2022
@mhiro2 mhiro2 requested a review from minikomi January 25, 2022 02:54
minikomi
minikomi approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@minikomi minikomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mhiro2 mhiro2 merged commit 7c7ab39 into main Jan 25, 2022
@mhiro2 mhiro2 deleted the mhiro2/remove-support-for-python-3-10 branch January 25, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikomi minikomi minikomi approved these changes

Assignees

@mhiro2 mhiro2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhiro2 @minikomi