Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string tenant_id; change tenancy #66

Closed

Conversation

ramontayag
Copy link
Contributor

@ramontayag ramontayag commented Apr 22, 2016

This is a breaking change. See notes in CHANGELOG.md.

@ramontayag ramontayag force-pushed the support_string_tenant_id branch from c3957b9 to 93ce285 Compare July 12, 2016 03:49
@pjohnmeyer
Copy link

Hello, long time plutus watcher first time commenter. 😃

@ramontayag I was wondering, why did you decide to, essentially, make multi-tenancy "always-on" and polymorphic as part of this pull? I can see that it simplifies some things a good bit, but it also seems like a separate change from the "support string tenant_id" change.

Also, doesn't plutus already support stringy tenant id's? Perhaps it's not obvious from the documentation, but I believe this "just works" today, if you change the column type before running the multi-tenancy migration.

@ramontayag
Copy link
Contributor Author

@pjohnmeyer - you're right! It is separate and should be a separate pull request. I'll change it.

As for your second question: yes it will work if you change it before running the migrations.

@ramontayag
Copy link
Contributor Author

@pjohnmeyer, thanks for pointing that out. Cheers!

#79

@ramontayag ramontayag closed this Sep 1, 2016
@ramontayag ramontayag deleted the support_string_tenant_id branch September 1, 2016 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants