Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Response when Polly is disabled #13

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Jun 18, 2024

When Polly is disabled, Watts was returning an empty string. To better simulate prod, I added a static mp3 file for it to return instead. Audio reads This is sample audio for Watts. This is a sample audio file. Text-to-speech is disabled in this environment..


@cmaddox5 cmaddox5 requested a review from a team as a code owner June 18, 2024 15:06
Copy link

Coverage of commit 89ee889

Summary coverage rate:
  lines......: 6.1% (2 of 33 lines)
  functions..: 33.3% (2 of 6 functions)
  branches...: no data found

Files changed coverage rate:
                          |Lines       |Functions  |Branches    
  Filename                |Rate     Num|Rate    Num|Rate     Num
  ==============================================================
  lib/web_api.ex          | 3.1%     32|20.0%     5|    -      0

Download coverage report

Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing: it might be nice if the sample audio "explained itself" a bit better for the sake of non-developers who may hear it. Something like "This is a sample audio file. Text-to-speech is disabled in this environment."

Copy link

Coverage of commit 3cb8f4e

Summary coverage rate:
  lines......: 6.1% (2 of 33 lines)
  functions..: 33.3% (2 of 6 functions)
  branches...: no data found

Files changed coverage rate:
                          |Lines       |Functions  |Branches    
  Filename                |Rate     Num|Rate    Num|Rate     Num
  ==============================================================
  lib/web_api.ex          | 3.1%     32|20.0%     5|    -      0

Download coverage report

@cmaddox5 cmaddox5 merged commit 152d7ac into main Jun 20, 2024
2 checks passed
@cmaddox5 cmaddox5 deleted the cm/return-mp3-for-disabled-polly branch June 20, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants