Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: Add custom browserslist (#2290)" #2313

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

cmaddox5
Copy link
Contributor

GDS can't handle it so reverting it for now.

@cmaddox5 cmaddox5 requested a review from a team as a code owner November 22, 2024 16:39
@digitalcora
Copy link
Contributor

Though I think it's likely, I'd like to test that this will properly unblock us on deploying main before actually merging it. My proposal would be:

  • Deploy this branch to dev.
  • Temporarily update just one of the GDS E-inks to point to the dev version of its URL.
  • Monitor to see whether it continues making data requests. (Ideally, the only consequence is that the screen briefly shows "dev" in its header in small text, but otherwise displays the same information.)
  • Revert the update to the E-ink device, pointing it back to production.
  • Assuming this test was successful, merge this branch and deploy to production.

Let me know if that makes sense.

@cmaddox5
Copy link
Contributor Author

Picking EIB-101 to test this out. Copied its prod config into dev. Will let the branch sit for about 10 minutes and then update the URL.

@cmaddox5
Copy link
Contributor Author

Starting to see successful api requests: https://mbta.splunkcloud.com/en-US/app/search/search?sid=1732308914.7805057. I think this was the issue like we thought. Will leave this up for ~10 more minutes, switch the URL, and merge the change after approval. Then we can deploy main again.

@cmaddox5
Copy link
Contributor Author

Still looking good: https://mbta.splunkcloud.com/en-US/app/search/search?sid=1732309570.7807810. I'm now confident in this being the issue.

Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in approving, I misremembered that I had already approved it and so thought the ball was still in your court. Seems like this will fix things for now.

@cmaddox5 cmaddox5 merged commit c98aa3e into main Nov 26, 2024
14 checks passed
@cmaddox5 cmaddox5 deleted the revert-2290-cm/add-browserslist branch November 26, 2024 15:45
cmaddox5 added a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants