fix: Handle LastTrip polling errors #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
force-pushed
the
cm/handle-last-trip-errors
branch
2 times, most recently
from
1c3da71
to
a5b34cc
Compare
cmaddox5
force-pushed
the
cm/handle-last-trip-errors
branch
from
a5b34cc
to
9e9a7d9
Compare
cmaddox5
commented
Nov 22, 2024
digitalcora
reviewed
Nov 22, 2024
digitalcora
approved these changes
Nov 22, 2024
|
Left this branch on dev-green over the weekend. Splunk results are positive. Error occurred pretty much everyday until Friday. Hasn't happened at all since Thursday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been getting quite a few errors related to the
LastTrip.Poller: https://mbtace.sentry.io/issues/5876255748/events/00f99016b99f4da49dbd9efd4191a83f/. It seems like we sometimes read the file and there is nothing in it.Jason.decodedoesn't particular like this so throws an error which causes the process to crash. I'm not 100% sure if the file being empty is normal, but I also don't think we should crash constantly because of it. The timer for the process is every second so we will catch the new data as soon as it's published anyway.