Migrate to ESLint and resolve lint errors #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously thought using Webpack 4 was an obstacle to upgrading beyond Node 16, but it turns out there was a point release specifically to enable it to work with later versions.
TSLint was deprecated in favor of ESLint several years ago: palantir/tslint#4534 Additionally, running the linter has not been part of CI, so (much like type-checking and formatting) we've accumulated many lint issues in the code over time. Rules where we have a huge number of outstanding issues (primarily `no-explicit-any` and `prop-types`) are set to `warn` for the time being, so they are still visible but won't fail CI. Remaining issues have been cleaned up.
cmaddox5
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSLint was deprecated in favor of ESLint several years ago: palantir/tslint#4534
Additionally, running the linter has not been part of CI, so (much like type-checking and formatting) we've accumulated many lint issues in the code over time.
Rules where we have a huge number of outstanding issues (primarily
no-explicit-anyandprop-types) are set towarnfor the time being, so they are still visible but won't fail CI. Remaining issues have been cleaned up.