Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint and resolve lint errors #2041

Merged
merged 3 commits into from
May 3, 2024
Merged

Migrate to ESLint and resolve lint errors #2041

merged 3 commits into from
May 3, 2024

Conversation

digitalcora
Copy link
Contributor

@digitalcora digitalcora commented May 2, 2024

TSLint was deprecated in favor of ESLint several years ago: palantir/tslint#4534

Additionally, running the linter has not been part of CI, so (much like type-checking and formatting) we've accumulated many lint issues in the code over time.

Rules where we have a huge number of outstanding issues (primarily no-explicit-any and prop-types) are set to warn for the time being, so they are still visible but won't fail CI. Remaining issues have been cleaned up.


We previously thought using Webpack 4 was an obstacle to upgrading
beyond Node 16, but it turns out there was a point release specifically
to enable it to work with later versions.
TSLint was deprecated in favor of ESLint several years ago:
palantir/tslint#4534

Additionally, running the linter has not been part of CI, so (much like
type-checking and formatting) we've accumulated many lint issues in the
code over time.

Rules where we have a huge number of outstanding issues (primarily
`no-explicit-any` and `prop-types`) are set to `warn` for the time
being, so they are still visible but won't fail CI. Remaining issues
have been cleaned up.
@digitalcora digitalcora marked this pull request as ready for review May 2, 2024 19:38
@mbta mbta deleted a comment from github-actions bot May 2, 2024
@digitalcora digitalcora requested a review from cmaddox5 May 2, 2024 19:48
Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for all of the code health work you have done so far.

@cmaddox5 cmaddox5 assigned digitalcora and unassigned cmaddox5 May 3, 2024
@digitalcora digitalcora merged commit ef1f324 into main May 3, 2024
11 checks passed
@digitalcora digitalcora deleted the cfg-eslint branch May 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants