Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Erlang 26.2.5 #814

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: Erlang 26.2.5 #814

wants to merge 1 commit into from

Conversation

bklebe
Copy link
Contributor

@bklebe bklebe commented Jun 4, 2024

Summary of changes

Asana Ticket: TICKET_NAME

[Please include a brief description of what was changed]

@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch 11 times, most recently from dd61620 to 37979d8 Compare June 5, 2024 18:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Coverage of commit 37979d8

Summary coverage rate:
  lines......: 89.1% (4222 of 4737 lines)
  functions..: 71.0% (2259 of 3183 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/alb_monitor/lib/alb_monitor/monitor.ex                           |96.2%     26|92.9%    14|    -      0
  apps/api_accounts/lib/api_accounts.ex                                 |91.7%    109|83.3%    42|    -      0
  apps/fetch/lib/fetch/worker.ex                                        |89.0%     82| 100%    15|    -      0
  apps/parse/lib/parse/commuter_rail_occupancies.ex                     | 100%     16| 100%     5|    -      0
  apps/state/lib/logger.ex                                              | 100%      3| 100%     1|    -      0
  apps/state/lib/state/facility.ex                                      |90.0%     20|61.7%    47|    -      0
  apps/state/lib/state/stop.ex                                          |92.1%     76|92.6%    27|    -      0
  apps/state_mediator/lib/state_mediator/mediator.ex                    |58.3%     48|50.0%    16|    -      0

Download coverage report

@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch 5 times, most recently from 2618e00 to f3978bb Compare June 5, 2024 20:59
bklebe
bklebe commented Jun 5, 2024
View reviewed changes
apps/state/test/state/server_test.exs Outdated
@@ -251,7 +251,7 @@ defmodule State.ServerTest do
%Example{id: 2, data: :other}
])

assert [%{data: 38}, %{data: 44}, %{data: :other}] = HooksServer.all()
assert [%{data: :other}, %{data: 38}, %{data: 44}] = HooksServer.all()
Copy link
Contributor Author

@bklebe bklebe Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulswartz got a bit of a stumper here. With this update, my Mac wants this list to be in this order, while the Linux GHA runner wants it to be in the old order. I did some digging around in the OTP repo and couldn't find anything obvious that introduced this, but it seems like it might be a bug in Mnesia/ETS? Closed thing I found was this, which suggests the behavior observed on Mac is a regression: erlang/otp#6752.

@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch 4 times, most recently from 4e66267 to 4d1d9ec Compare June 5, 2024 22:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Coverage of commit 4d1d9ec

Summary coverage rate:
  lines......: 89.1% (4222 of 4737 lines)
  functions..: 71.0% (2259 of 3183 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/alb_monitor/lib/alb_monitor/monitor.ex                           |96.2%     26|92.9%    14|    -      0
  apps/api_accounts/lib/api_accounts.ex                                 |91.7%    109|83.3%    42|    -      0
  apps/fetch/lib/fetch/worker.ex                                        |89.0%     82| 100%    15|    -      0
  apps/parse/lib/parse/commuter_rail_occupancies.ex                     | 100%     16| 100%     5|    -      0
  apps/state/lib/logger.ex                                              | 100%      3| 100%     1|    -      0
  apps/state/lib/state/facility.ex                                      |90.0%     20|61.7%    47|    -      0
  apps/state/lib/state/stop.ex                                          |92.1%     76|92.6%    27|    -      0
  apps/state_mediator/lib/state_mediator/mediator.ex                    |58.3%     48|50.0%    16|    -      0

Download coverage report

@paulswartz
Copy link
Member

@bklebe given the size of this PR, is it possible to split it up into an Elixir upgrade (mostly formatting changes I think?) and an Erlang upgrade?

@bklebe
Copy link
Contributor Author

bklebe commented Jun 6, 2024

@paulswartz definitely!

@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch from 4d1d9ec to 13bc964 Compare June 6, 2024 17:24
@bklebe bklebe changed the title chore: Elixir 1.16.3, Erlang 26.2.5 chore: Erlang 26.2.5 Jun 6, 2024
@bklebe bklebe changed the base branch from master to beatrix/push/pvzpvwvmrtvy June 6, 2024 17:24
@bklebe bklebe force-pushed the beatrix/push/pvzpvwvmrtvy branch from 40f4a6b to b3fc38f Compare June 6, 2024 17:25
@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch from 13bc964 to f397995 Compare June 6, 2024 17:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Coverage of commit f397995

Summary coverage rate:
  lines......: 89.1% (4223 of 4737 lines)
  functions..: 71.0% (2259 of 3183 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@bklebe bklebe force-pushed the beatrix/push/pvzpvwvmrtvy branch from b3fc38f to 8f4d6c3 Compare June 6, 2024 17:33
@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch from f397995 to f4c253f Compare June 6, 2024 17:33
@bklebe bklebe force-pushed the beatrix/push/pvzpvwvmrtvy branch from 8f4d6c3 to 59dbb0f Compare June 6, 2024 17:36
@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch from f4c253f to 3602f6e Compare June 6, 2024 17:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Coverage of commit 3602f6e

Summary coverage rate:
  lines......: 89.1% (4221 of 4737 lines)
  functions..: 71.0% (2259 of 3183 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@bklebe bklebe force-pushed the beatrix/push/pvzpvwvmrtvy branch from 59dbb0f to 9ac98e7 Compare June 6, 2024 17:54
@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch 2 times, most recently from 762d462 to 636e765 Compare June 6, 2024 17:56
@bklebe bklebe force-pushed the beatrix/push/pvzpvwvmrtvy branch from 9ac98e7 to f59056a Compare June 6, 2024 17:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Coverage of commit 636e765

Summary coverage rate:
  lines......: 89.1% (4222 of 4737 lines)
  functions..: 71.0% (2259 of 3183 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@bklebe bklebe force-pushed the beatrix/push/pvzpvwvmrtvy branch from f59056a to 0cd0070 Compare June 6, 2024 18:52
@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch from 636e765 to e592254 Compare June 6, 2024 18:52
Base automatically changed from beatrix/push/pvzpvwvmrtvy to master June 6, 2024 18:59
@bklebe
chore: Erlang 26.2.5
c758562 
- Upgrades Sobelow and ignores a new false positive XSS warning
- Fixes a test failure caused by changes in :gen_server.start_link
- Fixes a test failure related to element ordering in ETS lookups
@bklebe bklebe force-pushed the beatrix/push/umprpxpqlkpw branch from e592254 to c758562 Compare June 6, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bklebe @paulswartz