Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metatag version info to the payload #14

Merged
merged 5 commits into from
Dec 12, 2023
Merged

add metatag version info to the payload #14

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be32f6f
add metatag version info to the payload
Need-less Dec 11, 2023
0ffb863
some changes to make the code look better meybe?
Need-less Dec 12, 2023
0ef122d
change a variable to const and update some tests to no longer stub, a…
Need-less Dec 12, 2023
a2ede04
make tests cleaner
Need-less Dec 12, 2023
e0412f7
change return behaviour of version getter
Need-less Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/stroeerCoreBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import {BANNER, VIDEO} from '../src/mediaTypes.js'
import * as utils from '../src/utils.js'
import {getGlobal} from '../src/prebidGlobal.js'



// Do not import POLYFILLS from core-js. Most likely until next major update (v4).
// Prebid.js committers updated core-js to version 3 on v3.19.0 release (9/5/2020).
// This broke imports. We need to be backwards compatible since this adapter is copied into
Expand Down Expand Up @@ -155,10 +153,14 @@ function groupBy(array, keyFns) {

function getVersionValues (win) {
const pbjs = getGlobal();
return {
var versionObject = {
Need-less marked this conversation as resolved.
Show resolved Hide resolved
yl: win.YLHH?.bidder?.settings?.version,
pb: pbjs.version
};

versionObject.mt = win?.SDG?.version && win.SDG.version()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.. i missed this initially. You can revert to returning as inline object. You can still do this:

return {
  yl: win.YLHH?.bidder?.settings?.version,
  pb: pbjs.version,
  mt: win?.SDG?.version && win.SDG.version()
}


return versionObject
}

function divideBidRequestsBySsat(bidRequests) {
Expand Down
35 changes: 30 additions & 5 deletions test/spec/modules/stroeerCoreBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,39 +871,64 @@ describe('stroeerCore bid adapter', function () {
describe('optional fields', () => {
describe('version fields', () => {
let pbVerStub
let mtVerStub

beforeEach(() => {
pbVerStub = sinon.stub(prebidGlobal, 'getGlobal')
win.SDG = {version: () => {
return ''
}}
mtVerStub = sinon.stub(win.SDG, 'version')
Need-less marked this conversation as resolved.
Show resolved Hide resolved
});

afterEach(() => {
pbVerStub.restore()
mtVerStub.restore()
});

it('gets version variables', () => {
pbVerStub.returns({version: '1.2'});
mtVerStub.returns('1.8');
win.YLHH.bidder.settings = {version: '1.1'};
const bidReq = buildBidderRequest();
const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq)[0];
assert.deepEqual(serverRequestInfo.data.ver, {'yl': '1.1', 'pb': '1.2'})
})
assert.deepEqual(serverRequestInfo.data.ver, {'yl': '1.1', 'pb': '1.2', 'mt': '1.8'});
});
it('functions with no pb value', () => {
pbVerStub.returns({version: undefined});
win.YLHH.bidder.settings = {version: '1.1'};
mtVerStub.returns('1.8');
const bidReq = buildBidderRequest();
const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq)[0];
assert.deepEqual(serverRequestInfo.data.ver, {'yl': '1.1', 'pb': undefined})
assert.deepEqual(serverRequestInfo.data.ver, {'yl': '1.1', 'pb': undefined, 'mt': '1.8'});
});
it('functions with no yl value', () => {
pbVerStub.returns({version: '2'});
mtVerStub.returns('1.8');
const bidReq = buildBidderRequest();
const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq)[0];
assert.deepEqual(serverRequestInfo.data.ver, {'pb': '2', 'yl': undefined, 'mt': '1.8'});
});
it('functions with no mt value', () => {
pbVerStub.returns({version: '1.2'});
win.YLHH.bidder.settings = {version: '1.1'};
mtVerStub.returns(undefined);
const bidReq = buildBidderRequest();
const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq)[0];
assert.deepEqual(serverRequestInfo.data.ver, {'yl': '1.1', 'pb': '1.2', 'mt': undefined});
});
it('functions with no mt version function', () => {
pbVerStub.returns({version: '1.2'});
win.YLHH.bidder.settings = {version: '1.1'};
const bidReq = buildBidderRequest();
const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq)[0];
assert.deepEqual(serverRequestInfo.data.ver, {'pb': '2', 'yl': undefined})
assert.deepEqual(serverRequestInfo.data.ver, {'yl': '1.1', 'pb': '1.2', 'mt': undefined});
});
it('functions with no values', () => {
pbVerStub.returns({version: undefined});
const bidReq = buildBidderRequest();
const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq)[0];
assert.deepEqual(serverRequestInfo.data.ver, {'yl': undefined, 'pb': undefined})
assert.deepEqual(serverRequestInfo.data.ver, {'yl': undefined, 'pb': undefined, 'mt': undefined});
});
});
it('should use ssat value from config', () => {
Expand Down