Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing peer dep warning in yarn v2 #1035

Merged
merged 2 commits into from
Sep 23, 2019
Merged

fix: Missing peer dep warning in yarn v2 #1035

merged 2 commits into from
Sep 23, 2019

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Aug 26, 2019

Related Issue

yarnpkg/berry#3

Description

In the upcoming yarn v2 packages should either explicitly provide missing peer deps or forward them

Related PRs

N/A

Impacted Areas in Application

Installing the package

Additional Notes

Fixes the following warnings currently created when install this package with yarn v2:

➤ YN0002: │ material-table@npm:1.50.0 [V] doesn't provide @date-io/core@^1.3.6 requested by @material-ui/pickers@npm:3.2.4
➤ YN0002: │ material-table@npm:1.50.0 [V] doesn't provide react@^16.8.4 requested by @material-ui/pickers@npm:3.2.4
➤ YN0002: │ material-table@npm:1.50.0 [V] doesn't provide react-dom@^16.8.4 requested by @material-ui/pickers@npm:3.2.4
➤ YN0002: │ material-table@npm:1.50.0 [V] doesn't provide react@^16.8.5 requested by react-beautiful-dnd@npm:11.0.3
➤ YN0002: │ material-table@npm:1.50.0 [V] doesn't provide react@>= 0.14.7 requested by react-double-scrollbar@npm:0.0.15

package.json Outdated Show resolved Hide resolved
Copy link
Owner

@mbrn mbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution

@mbrn mbrn merged commit f9ab8b5 into mbrn:master Sep 23, 2019
@eps1lon eps1lon deleted the patch-1 branch September 23, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants