Fixing pickling directory info #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing formatting
eiriktsarpalis
requested changes
May 11, 2018
|
Fixed, do you think a comment would be useful explaining why the unsupported check is now part way down the list? |
|
Sure, maybe even a test that demonstrates DirectoryInfo is serializable using a custom pickler would be good. |
Adding comment explaining move
Adding a test to show that serialising a directory info works.
Moving test to xml serialiser
eiriktsarpalis
approved these changes
May 14, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our issue regarding the pickling of a directory info. I've chosen to move the custom pickler up, rather than changing where the isUnsupportedType check happens. The rationale behind this is that if a user provides a custom pickler that is probably what should be used.