-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: manifest v3 (#916) #1608
base: v5
Are you sure you want to change the base?
Conversation
the reason im doing this pr in the first place is that this migration is kinda a blocker for chrome support: promise-based apis are only available in mv3, and ext store doesn't allow publishing mv2 anymore i really wanted to do that, since chrome finally has an api for side panels and it would be really cool to get sidebery (at least partially) working there |
Thanks for starting working on it!
so all these features will be broken without replacing
There are no tests, since this project for fun, and writing tests is not fun for me... so only manual e2e testing To get it merged, we need:
|
thanks for the details, i appreciate that, they really helped!~ i fixed everything except the "Optimize background to non-persistant mode" part. bgscript.mp4definitely not the best way, but considering how much sidebery relies on the background script - i feel like it's good enough |
@mbnuqw and @kunokareal |
im not an expert on extensions, but i think changing that id might lead to unintended side effects like resetting storage and braking ota updates. in any case, i think its better to keep things focused and for you to open a pr of your own that deals with that. |
i'm not entirely sure i did everything, this seems like too few changes for a v3 migration. sorry for being dumb in advance.
one thing im most unsure about is this part:
i've seen quite a few usages of executeScript, but the extension seems to be working fine despite using them?
and i also didn't really understand what those calls are used for in the first place
also im not sure how do i do a regression test, there don't seem to be any kind of tests in the repo
closes #916