Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/laravel v10 upgrade AB#35895 #100

Merged
merged 11 commits into from
Jan 22, 2024
Merged

Conversation

hayleyberryl2s
Copy link
Contributor

No description provided.

Copy link
Contributor

@rsloan-mlbsolutions rsloan-mlbsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Haley, I think that "^8.0||^9.0|^10" is meant to be "^8.0||^9.0||^10" (double line between the 9 and 10 versions) which is why the non 8 version tests are failing.

@hayleyberryl2s
Copy link
Contributor Author

hayleyberryl2s commented Dec 15, 2023

Hi Haley, I think that "^8.0||^9.0|^10" is meant to be "^8.0||^9.0||^10" (double line between the 9 and 10 versions) which is why the non 8 version tests are failing.

Updated; thank you 😀. I don't think that's why tests are failing though, it seems it's trying to SELECT .. FROM users but that table doesn't exist in the context of the test. I'm looking into it now.

@hayleyberryl2s hayleyberryl2s changed the title Feature/laravel v10 upgrade Feature/laravel v10 upgrade AB#35904 Dec 27, 2023
@hayleyberryl2s hayleyberryl2s changed the title Feature/laravel v10 upgrade AB#35904 Feature/laravel v10 upgrade AB#35895 Dec 27, 2023
@hayleyberryl2s hayleyberryl2s merged commit b2bbbdf into v4.x Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants