Tagged with rewrite #829
Merged
Tagged with rewrite #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seuros
reviewed
May 15, 2017
spec/acts_as_taggable_on/tag_spec.rb
Outdated
| context 'retry 3 times on not unique exception' do | ||
| it 'performs 3 tries before raising the exception' do | ||
| allow(ActsAsTaggableOn::Tag).to receive(:named_any).and_raise(ActiveRecord::RecordNotUnique.new('error')) # trigger error inside block | ||
| expect(ActiveRecord::Base.connection).to receive(:execute).with('ROLLBACK').exactly(3).times |
There was a problem hiding this comment.
expect(ActiveRecord::Base.connection).to receive(:execute).with('ROLLBACK').exactly(4).times
Datacleaner will rollback too.
Without datacleaner this test will rollback only 3 time.
seuros
reviewed
May 15, 2017
spec/acts_as_taggable_on/tag_spec.rb
Outdated
| @@ -170,7 +170,7 @@ | |||
|
|
|||
| context 'retry 3 times on not unique exception' do | |||
| it 'performs 3 tries before raising the exception' do | |||
| allow(ActsAsTaggableOn::Tag).to receive(:named_any).and_raise(ActiveRecord::RecordNotUnique) # trigger error inside block | |||
There was a problem hiding this comment.
This still apply for AR 4.2+ ?
seuros
reviewed
May 15, 2017
spec/acts_as_taggable_on/tag_spec.rb
Outdated
| @@ -171,7 +171,7 @@ | |||
| context 'retry 3 times on not unique exception' do | |||
| it 'performs 3 tries before raising the exception' do | |||
| allow(ActsAsTaggableOn::Tag).to receive(:named_any).and_raise(ActiveRecord::RecordNotUnique.new('error')) # trigger error inside block | |||
| expect(ActiveRecord::Base.connection).to receive(:execute).with('ROLLBACK').exactly(3).times | |||
| expect(ActiveRecord::Base.connection).to receive(:execute).with('ROLLBACK').exactly(4).times # one extra rollback from database cleaner | |||
There was a problem hiding this comment.
Let change the Datacleaner strategy to :deletion and correct the test
https://github.com/mbleigh/acts-as-taggable-on/blob/master/spec/support/database_cleaner.rb#L5
|
Thank you. |
This was referenced Mar 12, 2021
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite to have one SQL query for the array of tags and added missing test.