Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Rails < 4 #757

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Conversation

krzysiek1507
Copy link
Contributor

No description provided.

@krzysiek1507
Copy link
Contributor Author

@seuros

1 similar comment
@krzysiek1507
Copy link
Contributor Author

@seuros

@seuros
Copy link
Collaborator

seuros commented Jul 1, 2016

I will work on this today. Thanks for the ping.

@krzysiek1507 krzysiek1507 force-pushed the drop-rails3 branch 2 times, most recently from a1240a7 to a92da33 Compare July 1, 2016 17:48
@krzysiek1507
Copy link
Contributor Author

Rebased

@@ -1,11 +1,7 @@
module ActsAsTaggableOn::Compatibility
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we don't need this module now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seuros it's used here, so if we want to drop this module, we have to change API or extract parser for options

@seuros seuros merged commit 280b120 into mbleigh:master Jul 1, 2016
@krzysiek1507
Copy link
Contributor Author

Thanks!

@krzysiek1507 krzysiek1507 deleted the drop-rails3 branch July 1, 2016 19:23
@seuros
Copy link
Collaborator

seuros commented Jul 1, 2016

@krzysiek1507 Thank you for your contribution

tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants