Rails 5: Tagger is optional in Tagging relation.

[klacointe]

Rails 5 automatically adds a presence validation on belongs_to associations:

• belongs_to should default to required: true rails/rails#18233
• http://edgeapi.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-belongs_to

[jaredcwhite]

I can confirm this resolves the ROLLBACK problem in Rails 5 when trying to save a model's tag list.

[query-string]

+1

[shlomizadok]

+1
(Tested, fixes the issue)

[cireficc]

Can this be merged? In the meantime, I've forked, applied the change to get it working, and am bundling my fork (with gem 'acts-as-taggable-on', github: 'cireficc/acts-as-taggable-on') instead of this repo. It works, but it's a temporary hack.

[rpazyaquian]

Any updates on this? It'd help a bunch.

[ygamretuta]

+1

for anyone lazy enough to not want to create a fork with just this 1-line fix, use mine:

gem 'acts-as-taggable-on', github: 'ygamretuta/acts-as-taggable-on'

you can just remove the github param once the author decides to merge OP's PR

[emcoding]

I created the fork on the latest master, and borrowed the oneliner from the posters above. Doesn't work for me. Did anyone got this working on the latest master?

Thanks y'all

@ everyone: you can use my fork; it is the latest master plus the oneliner provided by @klacointe
https://github.com/f3pix/acts-as-taggable-on

[seuros]

thank you

[connorshea]

@seuros will this be pushed to RubyGems any time soon? Thanks for your work here :)

[cireficc]

@connorshea If you need the fix now, you can just point your Gemfile to use Github:

gem 'acts-as-taggable-on', github: 'mbleigh/acts-as-taggable-on'

and then go back to RubyGems when a new version is pushed.

[connorshea]

@cireficc we have a policy against it for security and stability reasons, so unfortunately that won't work.

[emcoding]

@connorshea Not sure what you mean. I point to the github master, because of the latest fixes, and it works allright.

[connorshea]

@F3PiX I mean the company I work for (GitLab)

[logicminds]

Is this in a released gem yet?

[connorshea]

@logicminds yeah it's in 4.0.0.

[lucascaton]

Wouldn't this require a migration change as well? I'm saying that because t.references :tagger, polymorphic: true adds both tagger_type and tagger_id columns with null: false.

The following change (made on this migration) solved the issue I was having (null value in column "tagger_type" violates not-null constraint):

-      t.references :tagger, polymorphic: true
+      t.references :tagger, polymorphic: true, null: true