Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, I am using with rails 5 alpha. And I like acts-as-taggable-on. After use it, I found it was not suport rails 5, So I add the suport for it.
The main problem are
count
andquote_value
methods of activerecord.See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/sanitization.rb#L10 and https://github.com/rails/rails/blob/master/activerecord/lib/active_record/relation/calculations.rb#L38 .
I just add support for them, like this
🎱