Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rails 5.0.0 alpha support #673

Merged
merged 1 commit into from
Nov 11, 2015
Merged

Add rails 5.0.0 alpha support #673

merged 1 commit into from
Nov 11, 2015

Conversation

FlowerWrong
Copy link
Contributor

Nowadays, I am using with rails 5 alpha. And I like acts-as-taggable-on. After use it, I found it was not suport rails 5, So I add the suport for it.
The main problem are count and quote_value methods of activerecord.
See https://github.com/rails/rails/blob/master/activerecord/lib/active_record/sanitization.rb#L10 and https://github.com/rails/rails/blob/master/activerecord/lib/active_record/relation/calculations.rb#L38 .
I just add support for them, like this

def count(column_name = :all, options = {})
  ActsAsTaggableOn::Utils.active_record5? ? super(column_name) : super(column_name, options)
end

🎱

@seuros
Copy link
Collaborator

seuros commented Aug 1, 2015

We should drop support for rails 3.2 then, that will clean up the codebase a little bit.

seuros added a commit that referenced this pull request Nov 11, 2015
Add rails 5.0.0 alpha support
@seuros seuros merged commit fac92a9 into mbleigh:master Nov 11, 2015
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants