Fixed README

[seuros]

This is the correct syntax since rails 3

[bf4]

What was wrong with the README? (BTW, it's the same in the UPGRADING file)

[seuros]

The syntax was old.

[bf4]

Oh? Would you humor me with a source? Looks to me like it's still up-to-date? link.

Also, I don't know if this was intentional, but you removed the db:migrate task from running along with the migration installation.

[seuros]

The source is the link you just posted . It say : "If you have multiple engines that need migrations copied over, use railties:install:migrations" in our case we have just one so we using the first syntax.

I re-added the db:migrate to the README but omitted it from UPGRADING.

IMO it bad practice to place a migration in-line

[bf4]

My thought regarding running the two tasks together is that it is the expected use case and not everyone knows you can do that. On the other hand, following my logic, the rake command should also run db:test:prepare. Although I suppose I should then add a SCOPE option

What are the downsides? This is only run in dev

[seuros]

In a production env, the migrations are run automatically after the deploy.
While in dev, it will warn if there are migrations pending.

It is recommended to always look at the migration before doing them. Let say you added an index to some field before the gem maintainer released the update. Once you run the migration, it will fail because the index already exist, so a modification will be required.

Anyway, if you think i should add the db:migrate, i will do it.

[bf4]

Good point. Maybe then say install with... review the generated migrations... migrate?

[seuros]

I rebased and repushed .

[bf4]

Whoa.. so many commits... maybe just

git checkout master && git checkout -b backup_master && git checkout - && git fetch upstream && git reset --hard upstream/master
# make your changes, cherry-pick, whatever and commit
git push -f origin master

[seuros]

Thank you for your help @bf4

[bf4]

So, this file is read in by the gemspec and displayed post-install. That's why I didn't use the markdown or the fences.

Also, I think I was just following a pattern already in the gemspec.

In any case, if this file is renamed, we'll need to change the code in https://github.com/mbleigh/acts-as-taggable-on/blob/master/acts-as-taggable-on.gemspec#L21

[seuros]

I think i will revert this change