fix strict_case_match bug #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| if ActsAsTaggableOn.strict_case_match | ||
| existing_tag = existing_tags.detect { |tag| tag.name == tag_name } | ||
| else | ||
| comparable_tag_name = comparable_name(tag_name) |
There was a problem hiding this comment.
would it make more sense to move the check for ActsAsTaggableOn.strict_case_match into the :comparable_name method? I think it would make more sense there to just pass the name through when strict_case_match is one.
|
@bf4 You are right. I have moved it into :comparable_name method. Thanks for your advice. |
| @@ -72,12 +72,26 @@ | |||
| ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("AWESOME").should == [@tag] | |||
| end | |||
|
|
|||
| it "should find by name case sensitive" do | |||
| ActsAsTaggableOn.strict_case_match = true | |||
| lambda { | |||
There was a problem hiding this comment.
Please change syntax to expect { # code }.to change...
|
@bf4 Sure. It has been changed. |
bf4
added a commit
that referenced
this pull request
Jan 2, 2014
[Fix] Comparing tag names now respects strict_case_match
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
[Fix] Comparing tag names now respects strict_case_match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue from Issue #434