Fix build #430
Merged
Fix build #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned However, set force: true and didn't set indices Fixes test failures for postgresql:: No integer type has byte size 11. Use a numeric with precision 0 instead. https://travis-ci.org/mbleigh/acts-as-taggable-on/jobs/15196579 see rails/rails#6272
|
SQLITE3 tests failing on Travis, unable to duplicate locally or fix on Travis... |
Fixes SQLITE3 failures
| if defined?(Encoding) | ||
| string.to_s.force_encoding('BINARY') | ||
| else | ||
| string.to_s.mb_chars |
There was a problem hiding this comment.
SQLITE3 queries require 8 bit ascii, but mb_chars seems to occasionally render 'one' as some invalid utf-8 'o', which crashes sqlite3. This fixes that.
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.