Make UUID primary keys work #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase against master and force push? |
|
Done. On 10 December 2013 13:25, Benjamin Fleischer [email protected]:
|
|
Seems fine to me. I'd be surprised if a model id had single quotes in it. |
bf4
added a commit
that referenced
this pull request
Dec 10, 2013
Make UUID primary keys work by quoting them
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Make UUID primary keys work by quoting them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Rails 4 with UUID primary keys (postgres), which breaks some of the "hand crafted" taggable queries. UUIDs need to be handled as strings. I've put together a quick patch that simply puts single quotes around the ID values, which works and doesn't break integer primary keys. There's probably a more elegant solution to this though.