-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using mattr_accessor, fixes up to the postgres :limit issue. #404
Conversation
Any idea why the |
Can you rebase against master and force push? |
mattr_accessor is removed in (not sure which version of) ActiveSupport. This seems syntactically more correct than using class variables. I would be more interested in seeing something like a configuration object on ActsAsTaggableOn with an initializer in which these options could be configured. I'm not sure if there is a reason or particular use-case for not doing that, but moving it there would be a breaking change in the API for AATO.
So, the mattr_accessor issue is fixed in master, now, but the other changes are interesting. Will review. |
I'm using v2.4.1 and I having the error:
I suppose is related to this thread. How can I define my "acts-as-taggable-on" dependency in a I think the fixed version must be in "rubygems" in order to be able to be included in a |
@fguillen Yes, only bundler can install from source. Until someone with push access can release a new version of the gem, your options are to fork and release a temporary name-spaced build of your own, or to do so with your own gemserver. |
Thanks for the support @bf4 my workaround has been to add this require:
Before:
|
@fguillen that works |
This PR should be renamed to 'Add configuration initializer generator', no? |
Fixes travis builds up to the postgres limit issue #416 and #409.
As an added bonus, I also added an in stall generator which creates an
acts_as_taggable_on.rb
initializer to set up configuration options.