fix as_8bit_ascii changes argument's encoding

mbleigh · Jan 8, 2014 · 383c377 · 383c377
1 parent 9b3f87d
commit 383c377
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/acts_as_taggable_on/tag.rb b/lib/acts_as_taggable_on/tag.rb
@@ -113,7 +113,7 @@ def binary
 
       def as_8bit_ascii(string)
         if defined?(Encoding)
-          string.to_s.force_encoding('BINARY')
+          string.to_s.dup.force_encoding('BINARY')
         else
           string.to_s.mb_chars
         end

diff --git a/spec/acts_as_taggable_on/tag_spec.rb b/spec/acts_as_taggable_on/tag_spec.rb
@@ -194,6 +194,13 @@
       ActsAsTaggableOn::Tag.named('cool').should include(@tag)
       ActsAsTaggableOn::Tag.named('cool').should_not include(uppercase_tag)
     end
+
+    it "should not change enconding" do
+      name = "\u3042"
+      original_encoding = name.encoding
+      ActsAsTaggableOn::Tag.find_or_create_with_like_by_name(name)
+      name.encoding.should == original_encoding
+    end
   end
 
   describe "name uniqeness validation" do