Generate source maps from Handlebars plugin #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After thinking on it some more, I decided having source maps might be nice. Also, after reading the following, I realized it's actually quite expected: - https://rollupjs.org/troubleshooting/#warning-sourcemap-is-likely-to-be-incorrect Some helpful resources on source maps: - https://web.dev/articles/source-maps - https://developer.chrome.com/docs/devtools/javascript/source-maps/ - https://www.npmjs.com/package/magic-string
mbland
added a commit
that referenced
this pull request
Dec 2, 2023
Removed PluginTmpl.#options, which became obsolete in #25 (commit e768bcc). Made PluginImpl.#hasHelpers() and PluginImpl.#partialRegistration() private. Return the source map object from PluginImpl.#adjustSourceMap() instead of a JSON.stringified version. Though Handlebars.precompile() emits the source map as a string, I'm pretty sure Vite+Rollups ends up parsing it. Since #adjustSourceMap() already JSON.parses the string into an object, it seems worth returning the object instead of a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thinking on it some more, I decided having source maps might be nice. Also, after reading the following, I realized it's actually quite expected:
Some helpful resources on source maps: