Return compiled Handlebars string, no source maps #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally the compiled template was wrapped as the `code:` attribute of a return object. However, the only use for returning an object is if we're returning Handlebars source maps. Upon studying Handlebars source maps more closely, and experimenting locally by introducing errors here and there, they don't seem to be of much use. The existing error messages are fine, and I can't seem to find examples of Handebars source map usage online. Now options.compiler.srcName and options.compiler.destName are explicitly undefined, to ensure Handlebars.precompile() only returns a string in PluginImpl.compile(). If one day a use case arises where it would make sense to support Handlebars source maps, this should prove relatively straightforward to enable. However, it doesn't seem worth adding even that little bit of complexity now when any such use case isn't yet clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the compiled template was wrapped as the
code:attribute of a return object. However, the only use for returning an object is if we're returning Handlebars source maps.Upon studying Handlebars source maps more closely, and experimenting locally by introducing errors here and there, they don't seem to be of much use. The existing error messages are fine, and I can't seem to find examples of Handebars source map usage online.
Now options.compiler.srcName and options.compiler.destName are explicitly undefined, to ensure Handlebars.precompile() only returns a string in PluginImpl.compile().
If one day a use case arises where it would make sense to support Handlebars source maps, this should prove relatively straightforward to enable. However, it doesn't seem worth adding even that little bit of complexity now when any such use case isn't yet clear.