Merge pull request #54 from mbland/request-form-action-canonicalization

Add resolvedUrl() helper, apply to form action
mbland · Dec 17, 2023 · bb5c82f · bb5c82f
2 parents 5fb43ea + 2a439a9
commit bb5c82f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/strcalc/src/main/frontend/components/request.test.js b/strcalc/src/main/frontend/components/request.test.js
@@ -6,6 +6,7 @@
  */
 import { post, postForm, postOptions } from './request'
 import { afterEach, describe, expect, test, vi } from 'vitest'
+import { resolvedUrl } from '../test/helpers'
 
 // @vitest-environment jsdom
 describe('Request', () => {
@@ -70,7 +71,7 @@ describe('Request', () => {
       // causes form.action to become `#{document.location.origin}/fetch` in
       // every environment.
       const form = document.createElement('form')
-      const resolvedAction = `${document.location.origin}/fetch`
+      const resolvedAction = resolvedUrl('./fetch')
       const res = { foo: 'bar' }
       const fetchStub = setupFetchStub(JSON.stringify(res))
 

diff --git a/strcalc/src/main/frontend/test/helpers.js b/strcalc/src/main/frontend/test/helpers.js
@@ -10,6 +10,15 @@
  * @module test-helpers
  */
 
+/**
+ * Resolves URL path against the current document location
+ * @param {string} path - path to resolve
+ * @returns {string} - the result of resolving path against document.location
+ */
+export function resolvedUrl(path) {
+  return new URL(path, document.location.href).toString()
+}
+
 /**
  * Enables tests to load page URLs both in the browser and in Node using JSDom.
  */