Bump to v1.0.6, add jsdoc, merge lcov #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-ups from #23 and commit fdf3d58. I decided to add 'jsdoc' to devDependencies and add `pnpm jsdoc` to `pnpm test:ci` after all. Also, as promised in #23, I've added lcov-result-merger to merge the coverage-{jsdom,browser}/lcov.info files generated by `pnpm test:ci`. This should get Coveralls to report 100% coverage again.
Pull Request Test Coverage Report for Build 7465985870
💛 - Coveralls |
Not only did this fail to show test-modules/main.js as 100% covered, it dropped the coverage of lib/browser.js over 30%: - https://coveralls.io/builds/64970613 Oh well. Worth a try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups from #23 and commit fdf3d58.
I decided to add 'jsdoc' to devDependencies and add
pnpm jsdoctopnpm test:ciafter all.Also, as promised in #23, I've added lcov-result-merger to merge the coverage-{jsdom,browser}/lcov.info files generated by
pnpm test:ci. This should get Coveralls to report 100% coverage again.