Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End run-tests, publish-test-results actions early #6

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mbland
Copy link
Owner

@mbland mbland commented Dec 29, 2023

The publish-test-results GitHub Actions workflow would keep running even if it failed to download artifacts. run-tests would try to post coverage even if tests failed, when there was no coverage/lcov.info to send.

This change now prevents both of those steps from taking place if an earlier step failed.

The publish-test-results GitHub Actions workflow would keep running even
if it failed to download artifacts. run-tests would try to post coverage
even if tests failed, when there was no coverage/lcov.info to send.

This change now prevents both of those steps from taking place if an
earlier step failed.
@mbland mbland self-assigned this Dec 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7352380307

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7352309154: 0.0%
Covered Lines: 174
Relevant Lines: 174

💛 - Coveralls

@mbland mbland merged commit aa5b076 into main Dec 29, 2023
3 checks passed
@mbland mbland deleted the stop-publish-test-results-on-failure branch December 29, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants