Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "bin" to install jsdoc-cli-wrapper executable #5

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

mbland
Copy link
Owner

@mbland mbland commented Dec 29, 2023

With this, this module should be ready to publish (I think).


Also, in other news, this commit and its PR should finally trigger the coverage/coveralls GitHub Actions check. Coverage from pull requests and pushes to 'main' have posted coverage to Coveralls, the checks just haven't appeared.

The reason appeared to be because the repo appeared to be "ownerless" on https://coveralls.io/. I learned about this from:

The latter doc says there's no web UI to chance the owner. However, when I went to https://coveralls.io/github/mbland/jsdoc-cli-wrapper/settings, there was a button I clicked to claim ownership.

The button's not there anymore, so I suppose it should be fixed now. We'll see shortly.

With this, this module should be ready to publish (I think).

- https://docs.npmjs.com/cli/v10/configuring-npm/package-json#bin

---

Also, in other news, this commit and its PR should finally trigger the
coverage/coveralls GitHub Actions check. Coverage from pull requests and
pushes to 'main' have posted coverage to Coveralls, the checks just
haven't appeared.

The reason appeared to be because the repo appeared to be "ownerless" on
https://coveralls.io/. I learned about this from:

- lemurheavy/coveralls-public#1591 (comment)
- https://stackoverflow.com/a/76591886
- https://docs.coveralls.io/common-issues-and-troubleshooting#issue-not-getting-status-updates

The latter doc says there's no web UI to chance the owner. However, when
I went to https://coveralls.io/github/mbland/jsdoc-cli-wrapper/settings,
there was a button I clicked to claim ownership.

The button's not there anymore, so I suppose it should be fixed now.
We'll see shortly.
@mbland mbland self-assigned this Dec 29, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7352275240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7351773053: 0.0%
Covered Lines: 174
Relevant Lines: 174

💛 - Coveralls

@mbland
Copy link
Owner Author

mbland commented Dec 29, 2023

Yep, the Coveralls check is working!

@mbland mbland merged commit f0a06e1 into main Dec 29, 2023
3 checks passed
@mbland mbland deleted the jsdoc-cli-wrapper-executable branch December 29, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants