Bump to v1.0.1, update README, optimize stripJC() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripJsonComments() is now more compact, and hopefully efficient. In particular, the newline and whitespace checks now prevent the rest of the comparisons from executing if the current character is whitespace. Also shortened variable names to enable collapsing more lines. While normally this might hinder readability, I find it actually enhances it in this case. At the same time, I also updated some comments and added more explicit comments to explain why the conditions are organized as they are. Updated the README to make sure all the example index.html paths are file:// URLs. Also updated the "Multilanguage project" section to show mbland/tomcat-servlet-testing-example using the installed package.
Pull Request Test Coverage Report for Build 7371041035
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripJsonComments() is now more compact, and hopefully efficient. In particular, the newline and whitespace checks now prevent the rest of the comparisons from executing if the current character is whitespace.
Also shortened variable names to enable collapsing more lines. While normally this might hinder readability, I find it actually enhances it in this case. At the same time, I also updated some comments and added more explicit comments to explain why the conditions are organized as they are.
Updated the README to make sure all the example index.html paths are file:// URLs. Also updated the "Multilanguage project" section to show mbland/tomcat-servlet-testing-example using the installed package.