Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak stripJsonComments, add README license info #13

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

mbland
Copy link
Owner

@mbland mbland commented Dec 30, 2023

The stripJsonComments() tweak reorders the inComment conditional expressions to check curChar before the inComment value. This should save unnecessary inComment comparisons, while we always have to check curChar.

Also added copyright and license info to README.md. Not strictly necessary, but still nice to have. Makes the project look and feel more professional to me, too.

Made a few other typographic improvements to README.md as well.

@mbland mbland self-assigned this Dec 30, 2023
The stripJsonComments() tweak reorders the inComment conditional
expressions to check curChar before the inComment value. This should
save unnecessary inComment comparisons, while we always have to check
curChar.

Also added copyright and license info to README.md. Not strictly
necessary, but still nice to have. Makes the project look and feel more
professional to me, too.

Made a few other typographic improvements to README.md as well.
@mbland mbland force-pushed the strip-json-tweak-readme-copyright-license branch from f63c05e to 1d0f8a0 Compare December 30, 2023 18:09
@coveralls
Copy link

coveralls commented Dec 30, 2023

Pull Request Test Coverage Report for Build 7365592200

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7365178771: 0.0%
Covered Lines: 249
Relevant Lines: 249

💛 - Coveralls

@mbland mbland merged commit f1483da into main Dec 30, 2023
3 checks passed
@mbland mbland deleted the strip-json-tweak-readme-copyright-license branch December 30, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants