Fix else/if branch deletion on ternary unparse #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
fix/dispatch
branch
2 times, most recently
from
c781b9c to
bdde556
Compare
* But leave 3.1.2 explicit as it requires a special workaround due to a change between 3.1.2 and 3.1.3.
* Github runners for macosx have very high latency so using them for every build item slows development down significantly on CI times. * This reduces the macosx coverage to feedback where the macosx ruby platform has a chance to derivate and has cause unexpected issues: isolation tests, unit specs and mutant self coverage.
* If its guaranteed the original code must have been a ternary, and thus will also be unparsed as a ternary: Mutant cannot delete the if or else branches. * If its not guaranteed the original code was a ternary mutant can freely produce AST without if or else branch and unparser will know on how to generate equivalent AST.
mbj
force-pushed
the
fix/dispatch
branch
3 times, most recently
from
8f6605e to
8bc90a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crashing case from: #1374 but with a smaller more localized reproduction.