Fix crash on static send mutation #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. I think I must have introduced that one. |
|
Yeah, but I reviewed it. So no blame assigned. BTW: I think we need #1105 to handle these more gracefully, mutants AST is "to wide" to assume a dynlang can ever be correctly generate mutations in all cases. With types this would not happen. |
|
We could probably do some automated testing of removing arguments from sends, etc. in the meta and making sure they don't crash. I suspect there are more cases like this generally. Yeah, we very well might. My only concern about #1105 is that it will probably make it hard to receive bug reports since most users won't notice failures. That's still probably worth it, but a little unfortunate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.