-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Pillow 2.1.0 and above #50
Conversation
Awesome, thanks. Will this work with pillow < 2.1.0? |
I have tested the code with PIL version 1.1.7 and Pillow 2.0.0. There are no cut off letters. With Pillow 2.0.0 you get a little extra whitespace below the letters. |
Please accept PR, and upload new version to PyPI. |
Interesting, my Pillow version is 2.2.1 also, maybe I should have deactivated the noise filter to get a clearer Image.
could fix this ramaining issue. |
Still to small?
Problem is that size calculates before rotation. |
@mktums probably, but that'll work fine in Pillow 2.0 and PIL 1.1.7. |
Well, we can't use old Pillow, so problem is still here. |
Image size must be calculated with the distance of the text from the top of the image in mind.
I think it's OK, but doesn't image now seems too big? |
Hello! How it is going on? When it will be in main branch? |
We're quite yet ready to merge this as-is. |
For the time being i was able to get it running perfectly fine on Pillow 2.0
Live example: http://dermtermsapp.com/register/ |
@asaji captcha doesn't fit with Pillow==2.1+ For Pillow==2.0 all is working very well |
How soon can we expect that fix merged into master and updated at PyPI? |
Merged, thank you! |
Pillow changed the font rendering (python-pillow/Pillow#285). So I changed the calculation of the text size. Without this fix the text in the captcha is cut off at the bottom with newer Pillow versions.