Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device ram size is 40 kb, not 48 kB #128

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

JojoS62
Copy link

@JojoS62 JojoS62 commented Jan 21, 2023

Summary of changes

This fix is for correcting the ram size of F303CC device.
In total RAM+RAM1 it has 48 kB, but the regions are not continuous. SRAM has 40 kB, when 48 kB is set in the linker script, then the device fails to start because the stack pointer is in the Nirvana.

This error is also in arm-pack index.json in Mbed-OS.

Impact of changes

Important fix for this device. Currently, no boards are using this. It is a basically needed for new target ROBOTDYN_F303CC
(also called Blackpill F303, small Chinese breakout board).

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


in total RAM+RAM1 it has 48 kB, but the regions are not continous.
This error is also arm-pack index.json
JohnK1987
JohnK1987 previously approved these changes Jan 21, 2023
@JojoS62 JojoS62 marked this pull request as draft January 22, 2023 09:35
@JojoS62
Copy link
Author

JojoS62 commented Jan 22, 2023

thanks for reviewing,
I have changed the PR status to draft, because I want to add the remaning 8 kB of RAM in another section, so that it can be used also.

@JojoS62
Copy link
Author

JojoS62 commented Jan 30, 2023

I have send this PR to mbed-os and it is already merged. Can it be merged from there also to mbed-ce?
ARMmbed#15378

@JohnK1987 JohnK1987 self-requested a review January 30, 2023 17:05
@JohnK1987 JohnK1987 marked this pull request as ready for review January 30, 2023 17:08
@multiplemonomials multiplemonomials merged commit 2d7f242 into master Jan 31, 2023
@multiplemonomials multiplemonomials deleted the fix-F303-ramsize branch January 31, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants