Feature/62 klantcontact #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be merged after #61 |
bart-maykin
force-pushed
the
feature/62-klantcontact
branch
from
7347a66 to
5b57914
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 96.15% 96.28% +0.12%
==========================================
Files 99 107 +8
Lines 3508 3711 +203
==========================================
+ Hits 3373 3573 +200
- Misses 135 138 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bart-maykin
force-pushed
the
feature/62-klantcontact
branch
7 times, most recently
from
94070e0 to
fb1ef84
Compare
bart-maykin
force-pushed
the
feature/62-klantcontact
branch
from
fb1ef84 to
3533825
Compare
joeribekker
requested changes
Oct 18, 2023
Comment on lines
+11
to
+14
| id = models.UUIDField( | ||
| primary_key=True, | ||
| unique=True, | ||
| default=uuid.uuid4, |
There was a problem hiding this comment.
Suggested change
| id = models.UUIDField( | |
| primary_key=True, | |
| unique=True, | |
| default=uuid.uuid4, | |
| uuid = models.UUIDField( | |
| unique=True, | |
| default=uuid.uuid4, |
| ), | ||
| null=True, | ||
| ) | ||
| taal = models.CharField( |
There was a problem hiding this comment.
zelfde als partij opmerking. Pas wel even de helptekst aan zodat het nog klopt.
| ), | ||
| ) | ||
| # TODO: does this field require auto_now? | ||
| plaatsgevonden_op = models.DateTimeField( |
There was a problem hiding this comment.
je mag hier een default op zetten: default=timezone.now (zie django docs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Changed model structure
Added Klantcontact model