-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13] reuse open-api-workflows workflows #238
base: master
Are you sure you want to change the base?
Conversation
9f6a3d0
to
86c494a
Compare
This PR requires an updated version of OAF, see the code qualities job and the PR made in OAF. |
2f41a28
to
915a644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SonnyBA could you solve the merge conflicts? Also one of the jobs is failing, not sure why https://github.com/maykinmedia/open-klant/actions/runs/11178494784/job/31076178777?pr=238
12c5370
to
6a4a5f7
Compare
@stevenbal regarding the failing job, there still is this comment to consider before merging |
6a4a5f7
to
a20f0e3
Compare
but base it entirely off of base.txt
be3ae06
to
3c2c8be
Compare
3c2c8be
to
e80ba3d
Compare
this version moves the auth middleware to the proper directory, to avoid unnecessary migrations if the authorizations app is unused also remove the vng_api_common.authorizations.AuthMiddleware from the MIDDLEWARE setting, because Open Klant does not use JWT authentication
e80ba3d
to
c42cf93
Compare
@annashamray @Coperh @bart-maykin this PR is ready for review again |
echo './bin/generate_schema_for_component.sh ${{ matrix.component }}' >> $GITHUB_STEP_SUMMARY | ||
echo '```' >> $GITHUB_STEP_SUMMARY | ||
open-api-workflow-code-quality: | ||
uses: maykinmedia/open-api-workflows/.github/workflows/code-quality.yml@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is some confusion in the name of files. Here you check code quality (isort, black, etc.), but the file is codeql.yml
, but CodeQL check itself is added to another file
Fixes maykinmedia/open-api-framework#13
Changes
Reuses open-api-workflows workflows to make CI jobs consistent across the different projects.