[#13] reuse open-api-workflows workflows #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
9f6a3d0
to
86c494a
Compare
|
This PR requires an updated version of OAF, see the code qualities job and the PR made in OAF. |
2 tasks
SonnyBA
requested review from
stevenbal,
bart-maykin,
annashamray and
Coperh
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
2f41a28
to
915a644
Compare
stevenbal
reviewed
Oct 17, 2024
There was a problem hiding this comment.
@SonnyBA could you solve the merge conflicts? Also one of the jobs is failing, not sure why https://github.com/maykinmedia/open-klant/actions/runs/11178494784/job/31076178777?pr=238
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
12c5370
to
6a4a5f7
Compare
|
@stevenbal regarding the failing job, there still is this comment to consider before merging |
bart-maykin
approved these changes
Oct 24, 2024
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
6a4a5f7
to
a20f0e3
Compare
but base it entirely off of base.txt
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
be3ae06
to
3c2c8be
Compare
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
3c2c8be
to
e80ba3d
Compare
this version moves the auth middleware to the proper directory, to avoid unnecessary migrations if the authorizations app is unused also remove the vng_api_common.authorizations.AuthMiddleware from the MIDDLEWARE setting, because Open Klant does not use JWT authentication
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
e80ba3d
to
c42cf93
Compare
|
@annashamray @Coperh @bart-maykin this PR is ready for review again |
annashamray
requested changes
Oct 25, 2024
| echo './bin/generate_schema_for_component.sh ${{ matrix.component }}' >> $GITHUB_STEP_SUMMARY | ||
| echo '```' >> $GITHUB_STEP_SUMMARY | ||
| open-api-workflow-code-quality: | ||
| uses: maykinmedia/open-api-workflows/.github/workflows/code-quality.yml@v1 |
There was a problem hiding this comment.
It looks like there is some confusion in the name of files. Here you check code quality (isort, black, etc.), but the file is codeql.yml, but CodeQL check itself is added to another file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes maykinmedia/open-api-framework#13
Changes
Reuses open-api-workflows workflows to make CI jobs consistent across the different projects.