Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Als projectmanager wil ik een nummergenerator voor functionele nummers in de API #103

Closed
2 tasks
joeribekker opened this issue Nov 6, 2023 · 0 comments · Fixed by #142
Closed
2 tasks

Als projectmanager wil ik een nummergenerator voor functionele nummers in de API #103

joeribekker opened this issue Nov 6, 2023 · 0 comments · Fixed by #142
Assignees
@joeribekker @bart-maykin
Labels
enhancement New feature or request owner: maykin owner: vng topic: api
Milestone
Release 2.0.0

Comments

@joeribekker
Copy link
Member

joeribekker commented Nov 6, 2023 •
edited
Loading

..zodat ik niet zelf de nummers hoef te genereren.

Tasks

  • Everywhere where there is a "nummer"-attribute, this should automatically get a human friendly number if it is left empty.
  • We can simply make this an incremental number that starts at 1 by doing aggregate(models.Max("nummer"))["nummer__max"] + 1 in the save method and make the transaction atomic.

Uiteindelijk gaan we waarschijnlijk naar: https://github.com/maykinmedia/commonground-api-common/blob/9c1c538705cf6b4f4b024779e3e91805b287b01d/vng_api_common/utils.py#L208

maar dan moet deze goedgekeurd worden: VNG-Realisatie/klantinteracties#273

Verder is dit een invulling van: VNG-Realisatie/klantinteracties#242

Achtergrond

Kijk even naar Open Zaak hiervoor, maar het formaat mag zonder context, dus gewoon een integer maar dan oplopend. Ik zou de "nummer" velden het liefst strings maken, zodat we voorloopnullen kunnen hebben. Even met VNG overleggen.

In Open Zaak is er een aparte tabel om race-condities te voorkomen. Dat moet hier ook.
@joeribekker joeribekker added this to the Release 0.7.0 milestone Nov 6, 2023
@joeribekker joeribekker self-assigned this Nov 6, 2023
@joeribekker joeribekker changed the title Alss projectmanager wil ik een nummergenerator voor functionele nummers in de API Als projectmanager wil ik een nummergenerator voor functionele nummers in de API Nov 6, 2023
@joeribekker joeribekker modified the milestones: Release 0.7.0, Release 0.6.0 Dec 21, 2023
@bart-maykin bart-maykin moved this from Todo to In progress in Open Klant development Jan 16, 2024
bart-maykin added a commit that referenced this issue Jan 16, 2024
@bart-maykin
✨ [#103] added nummer generator for all nummer fields
8444eac
@bart-maykin bart-maykin mentioned this issue Jan 16, 2024
Merged
@bart-maykin bart-maykin moved this from In progress to Implemented in Open Klant development Jan 16, 2024
bart-maykin added a commit that referenced this issue Jan 16, 2024
@bart-maykin
✨ [#103] added nummer generator for all nummer fields
7d10fe5
bart-maykin added a commit that referenced this issue Jan 17, 2024
@bart-maykin
🎨 [#103] made number_generator to util func
e5525cd
joeribekker added a commit that referenced this issue Jan 26, 2024
@joeribekker
Merge pull request #142 from maykinmedia/feature/103-number-generator
19a0d9b 
✨ [#103] added nummer generator for all nummer fields
@github-project-automation github-project-automation bot moved this from Implemented to Done in Open Klant development Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeribekker joeribekker

@bart-maykin bart-maykin

Labels
enhancement New feature or request owner: maykin owner: vng topic: api
Projects
No open projects
Open Klant development
Archived in project
Milestone
Release 2.0.0
Development

Successfully merging a pull request may close this issue.

✨ [#103] added nummer generator for all nummer fields maykinmedia/open-klant
2 participants
@joeribekker @bart-maykin