💄 [#1677] Making cookiebanner margins and modal same on mobile #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
changed the title
jiromaykin
changed the title
jiromaykin
force-pushed
the
feature/1677-make-mobile-cookiebanner-modal
branch
2 times, most recently
from
60fc70f
to
02ee1a5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #737 +/- ##
========================================
Coverage 96.27% 96.27%
========================================
Files 674 674
Lines 24007 24007
========================================
Hits 23113 23113
Misses 894 894 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jiromaykin
force-pushed
the
feature/1677-make-mobile-cookiebanner-modal
branch
from
f64cd7b
to
4f2b54d
Compare
jiromaykin
force-pushed
the
feature/1677-make-mobile-cookiebanner-modal
branch
from
e0285cb
to
95eaaac
Compare
pi-sigma
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to test/review this: if you have previously clicked on the cookiebanner (making it invisible), you can make it appear in your browser again by looking in your Dev Tools for an >> Application >> Cookies/Local Storage tab and delete the "cookieBannerAccepted" cookie, or in >> Storage Tab >> Cookies >> localhost and remove "cookieBannerAccepted" (usually delete cookies via right-click)
https://taiga.maykinmedia.nl/project/open-inwoner/task/1677