Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2931] Update company name from KVK API on login #1533

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pi-sigma
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (2429bd2) to head (3519727).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1533   +/-   ##
========================================
  Coverage    94.12%   94.13%           
========================================
  Files         1064     1064           
  Lines        39204    39233   +29     
========================================
+ Hits         36901    36931   +30     
+ Misses        2303     2302    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review December 19, 2024 13:02
@pi-sigma pi-sigma requested a review from swrichards December 19, 2024 13:02
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about a test, but treat it as a nitpick.

@pi-sigma pi-sigma marked this pull request as draft December 19, 2024 14:08
@pi-sigma pi-sigma force-pushed the task/2931-update-company-login branch from 39335d7 to 3519727 Compare December 19, 2024 14:28
@pi-sigma pi-sigma requested a review from swrichards December 19, 2024 14:51
@pi-sigma pi-sigma marked this pull request as ready for review December 19, 2024 14:51
@pi-sigma pi-sigma requested a review from alextreme December 19, 2024 15:02
@alextreme alextreme merged commit 0564935 into develop Dec 19, 2024
20 checks passed
@alextreme alextreme deleted the task/2931-update-company-login branch December 19, 2024 18:42
pi-sigma pushed a commit that referenced this pull request Dec 20, 2024
[#2931] Update company name from KVK API on login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants