Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2838] Make OpenKlant2 client compatible with zgw_consumers logic #1472

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[#2838] Make OpenKlant2 client compatible with zgw_consumers logic #1472

merged 2 commits into from
Oct 28, 2024
+39 −22

Conversation

swrichards
Copy link
Contributor

@swrichards
Copy link
Contributor Author

swrichards commented Oct 24, 2024 •
edited
Loading

Merge after #1452 done.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.59%. Comparing base (2327a68) to head (4f586eb).

Files with missing lines Patch % Lines
src/open_inwoner/openklant/models.py 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1472      +/-   ##
===========================================
- Coverage    94.59%   94.59%   -0.01%     
===========================================
  Files         1063     1063              
  Lines        39715    39725      +10     
===========================================
+ Hits         37569    37578       +9     
- Misses        2146     2147       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards marked this pull request as ready for review October 24, 2024 15:46
@swrichards swrichards force-pushed the tasks/2838-ok2-client-zgw-consumers-compat branch from 8686b7a to cd8011f Compare October 25, 2024 08:19
@swrichards swrichards mentioned this pull request Oct 25, 2024
Merged
pi-sigma
pi-sigma approved these changes Oct 28, 2024
View reviewed changes
src/open_inwoner/openklant/models.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the tasks/2838-ok2-client-zgw-consumers-compat branch from cd8011f to 4f586eb Compare October 28, 2024 11:56
@alextreme alextreme merged commit 40bc625 into develop Oct 28, 2024
20 checks passed
@alextreme alextreme deleted the tasks/2838-ok2-client-zgw-consumers-compat branch October 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-sigma pi-sigma pi-sigma approved these changes

@alextreme alextreme Awaiting requested review from alextreme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swrichards @codecov-commenter @pi-sigma @alextreme