Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize list params in an OK2 supported format #1420

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards commented Oct 3, 2024

This is necessary to deal with maykinmedia/open-klant#250

@swrichards swrichards force-pushed the serialize-ok2-query-params-correctly branch from 0eedcbf to 7309047 Compare October 3, 2024 10:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (f1745d2) to head (74f6c41).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1420   +/-   ##
========================================
  Coverage    94.85%   94.85%           
========================================
  Files         1049     1049           
  Lines        38837    38845    +8     
========================================
+ Hits         36840    36848    +8     
  Misses        1997     1997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards marked this pull request as ready for review October 3, 2024 10:41
@swrichards swrichards requested a review from pi-sigma October 3, 2024 10:41
src/openklant2/_resources/base.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the serialize-ok2-query-params-correctly branch from 7309047 to 74f6c41 Compare October 3, 2024 10:47
@swrichards swrichards requested a review from alextreme October 3, 2024 11:58
@alextreme alextreme merged commit f081910 into develop Oct 3, 2024
20 checks passed
@alextreme alextreme deleted the serialize-ok2-query-params-correctly branch October 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants