Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2752] Add math captcha to contactform #1417

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Oct 1, 2024

@pi-sigma pi-sigma force-pushed the task/2752-captcha branch 2 times, most recently from 632eece to f1fcd3a Compare October 1, 2024 11:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (1ce73db) to head (cd85a8d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1417   +/-   ##
========================================
  Coverage    94.85%   94.85%           
========================================
  Files         1048     1049    +1     
  Lines        38783    38837   +54     
========================================
+ Hits         36786    36840   +54     
  Misses        1997     1997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2752-captcha branch 4 times, most recently from 107f20b to 211fcb0 Compare October 1, 2024 15:04
@pi-sigma pi-sigma force-pushed the task/2752-captcha branch 3 times, most recently from c8a62e9 to b400787 Compare October 2, 2024 07:27
@pi-sigma pi-sigma marked this pull request as ready for review October 2, 2024 07:48
@pi-sigma pi-sigma requested a review from swrichards October 2, 2024 07:49
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks/FYIs really, also happy to merge this as-is. LGTM.

src/open_inwoner/utils/forms.py Outdated Show resolved Hide resolved
src/open_inwoner/utils/forms.py Show resolved Hide resolved
src/open_inwoner/openklant/forms.py Outdated Show resolved Hide resolved
src/open_inwoner/utils/forms.py Show resolved Hide resolved
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
(Also because I need this to merge for proper translations)

</label>
<div class="captcha__check">
<div>
<span class="captcha__prompt">{{ form_object.captcha.field.question }}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's rename it :-)

@alextreme alextreme merged commit f1745d2 into develop Oct 3, 2024
20 checks passed
@alextreme alextreme deleted the task/2752-captcha branch October 3, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants