[#2771] Add support for fetching open submissions with KVK #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our caching mechanism: does not work properly when applied to the methods of the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1411 +/- ##
===========================================
- Coverage 94.89% 94.88% -0.01%
===========================================
Files 1046 1045 -1
Lines 38612 38682 +70
===========================================
+ Hits 36640 36704 +64
- Misses 1972 1978 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swrichards
requested changes
Sep 26, 2024
pi-sigma
force-pushed
the
task/2771-open-submissions
branch
from
07846f7
to
1d80632
Compare
swrichards
reviewed
Sep 26, 2024
swrichards
requested changes
Sep 26, 2024
pi-sigma
force-pushed
the
task/2771-open-submissions
branch
3 times, most recently
from
91b6ce8
to
5119cae
Compare
swrichards
approved these changes
Sep 30, 2024
- The parameter `kvk_or_rsin` returned by the utility is split
into two parameters; it is now up to the caller to distinguish
between them. The utility becomes more flexible, which is needed
for fetching `openstaande inzendingen` with kvk (fetch with rsin
is not (yet) supported).
pi-sigma
force-pushed
the
task/2771-open-submissions
branch
from
5119cae
to
4cdf70e
Compare
swrichards
approved these changes
Sep 30, 2024
swrichards
pushed a commit
that referenced
this pull request
Sep 30, 2024
[#2771] Add support for fetching open submissions with KVK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2771