Handle URL rewriting for ZGW import/export #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
tasks/2726-zgw-import-fixes
branch
5 times, most recently
from
5c16d2c
to
513be5c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1395 +/- ##
========================================
Coverage 95.24% 95.25%
========================================
Files 1008 1008
Lines 37364 37463 +99
========================================
+ Hits 35589 35684 +95
- Misses 1775 1779 +4 ☔ View full report in Codecov by Sentry. |
pi-sigma
requested changes
Sep 12, 2024
| self.service = ServiceFactory(slug="service-0") | ||
| ServiceFactory(slug="service-1") | ||
| self.service = ServiceFactory( | ||
| slug="service-0", api_root="https://foo.0.maykinmedia.nl" |
There was a problem hiding this comment.
Suggested change
| slug="service-0", api_root="https://foo.0.maykinmedia.nl" | |
| slug="service-foo", api_root="https://foo.maykinmedia.nl" |
I find foo and bar more readable than foo.0 and foo.1. Would need to be changed below as well, though.
| slug="service-0", api_root="https://foo.0.maykinmedia.nl" | ||
| ) | ||
| self.other_service = ServiceFactory( | ||
| slug="service-1", api_root="https://foo.1.maykinmedia.nl" |
There was a problem hiding this comment.
Suggested change
| slug="service-1", api_root="https://foo.1.maykinmedia.nl" | |
| slug="service-bar", api_root="https://bar.maykinmedia.nl" |
There was a problem hiding this comment.
A bit pressed for time in this sprint, will fix this if I have a bit of spare time end-of-sprint (but it might be good to review the other changes).
swrichards
force-pushed
the
tasks/2726-zgw-import-fixes
branch
from
513be5c
to
358c9c7
Compare
pi-sigma
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga issues.
Essentially, what this does is rewrite all ZGW URLs in the import file to have the same URL root as the service on the target instance (matched on slug).
This is not an especially pretty or general-purpose fix, but it should solve the specific problem for Groningen (who is the only intended user of the feature thus far).