Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2744] Hide notifications if disabled via admin #1393

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Sep 10, 2024

Hide notifications if disabled via admin:

  • from the user profile
  • from registration

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2744

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (af6f72b) to head (80989e9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1393   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files         1008     1008           
  Lines        37370    37383   +13     
========================================
+ Hits         35595    35608   +13     
  Misses        1775     1775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2743-action-required-notifications branch from 658d1f2 to fcd922f Compare September 11, 2024 07:57
@pi-sigma pi-sigma marked this pull request as ready for review September 11, 2024 08:24
@alextreme
Copy link
Member

check the conflict

@pi-sigma pi-sigma force-pushed the task/2743-action-required-notifications branch from fcd922f to 80989e9 Compare September 12, 2024 11:38
@alextreme alextreme merged commit 56550aa into develop Sep 13, 2024
19 checks passed
@alextreme alextreme deleted the task/2743-action-required-notifications branch September 13, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants