Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2596] Disable scroll zoom on Productkaart homepage #1391

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Sep 10, 2024

feature: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2596

Disables the annoying zoom in the map (leaflet/"Productlocatie Plugin" CMS) on Homepage when you just want to scroll down.
tested in multiple browsers, including on BrowserStack.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (839dccf) to head (0eef8d2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1391   +/-   ##
========================================
  Coverage    95.24%   95.24%           
========================================
  Files         1008     1008           
  Lines        37364    37364           
========================================
  Hits         35589    35589           
  Misses        1775     1775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin marked this pull request as ready for review September 10, 2024 12:42
@alextreme
Copy link
Member

Finally, this has been bothering me for way too long thanks 👍

@alextreme alextreme merged commit 01da141 into develop Sep 12, 2024
19 checks passed
@alextreme alextreme deleted the feature/2596-scroll-map branch September 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants