[#dimpact-138] Fix creation of contactmoment without medewerker #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The creation of contactmomenten via the form under a particular
zaak was not possible without default medewerker set in the
Open Klant config. The issue had been fixed for the contfactform
(https://github.com/maykinmedia/open-inwoner/pull/1198/files), but
not for the case detail view.
pi-sigma
force-pushed
the
issue/contactmoment-medewerker
branch
from
5067b2f
to
d1043fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1380 +/- ##
========================================
Coverage 95.23% 95.24%
========================================
Files 1005 1005
Lines 37267 37290 +23
========================================
+ Hits 35492 35515 +23
Misses 1775 1775 ☔ View full report in Codecov by Sentry. |
swrichards
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of contactmomenten without default medewerker was fixed for the standalone contactform, but not for the form embedded in particular zaken.
Taiga:https://taiga.maykinmedia.nl/project/dimpact-enschede-ssc-ict-1/issue/138