💄 [#2703] Move upload-button for file-input closer to selection field #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
feature/2703-move-doc-upload-button
branch
from
3520f19
to
808ddc0
Compare
jiromaykin
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1373 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 1005 1005
Lines 37185 37185
========================================
Hits 35404 35404
Misses 1781 1781 ☔ View full report in Codecov by Sentry. |
jiromaykin
force-pushed
the
feature/2703-move-doc-upload-button
branch
from
4c4986c
to
67e6df8
Compare
jiromaykin
force-pushed
the
feature/2703-move-doc-upload-button
branch
from
a6f7e30
to
8332d93
Compare
jiromaykin
force-pushed
the
feature/2703-move-doc-upload-button
branch
from
936fede
to
b4fe312
Compare
jiromaykin
changed the title
jiromaykin
changed the title
pi-sigma
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2703
New design: https://taiga.maykinmedia.nl/project/open-inwoner/task/2702
Main changes in:
src/open_inwoner/templates/pages/cases/document_form.html
src/open_inwoner/components/templates/components/Form/FileInput.html
All the other changes have to do with the very broad icon font universal asterisk selector... which was messing up the styles from Buttons that contain the
button--icon-afterclass...Universal selectors are awful but we might switch to a different icon font at some point in the future, and then these style will be easier to spot/separate.
Test with BSN 111111110: http://localhost:8000/mijn-aanvragen/1/a3c98c9a-d3c9-4f64-9371-9c41fc5781ad/status/