[#2704] Filter contactmomenten by kanaal #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
from
c96a9a1
to
bb15898
Compare
pi-sigma
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1372 +/- ##
========================================
Coverage 95.24% 95.24%
========================================
Files 1006 1007 +1
Lines 37313 37347 +34
========================================
+ Hits 35538 35572 +34
Misses 1775 1775 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
5 times, most recently
from
ebb0c83
to
0ec9627
Compare
swrichards
requested changes
Aug 28, 2024
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
from
0ec9627
to
be2c5c8
Compare
swrichards
requested changes
Aug 28, 2024
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
from
be2c5c8
to
370e6ef
Compare
swrichards
approved these changes
Aug 28, 2024
alextreme
reviewed
Aug 30, 2024
| @@ -17,3 +17,20 @@ def safe_label(cls, value, default=""): | |||
| if default: | |||
| return default | |||
| return str(value).replace("_", " ").title() | |||
|
|
|||
|
|
|||
| class ContactmomentKanaalEsuite(models.TextChoices): | |||
There was a problem hiding this comment.
How sure are we that this enumeration is the same across multiple eSuite instances? As with most things eSuite, this is likely something which is configurable...
There was a problem hiding this comment.
Discussed, we'll replace the whitelist containing hard-coded strings with a blacklist to be entered by the admin (cf. https://taiga.maykinmedia.nl/project/open-inwoner/task/2724)
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
from
370e6ef
to
af93b6f
Compare
swrichards
requested changes
Sep 5, 2024
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
from
af93b6f
to
1379575
Compare
pi-sigma
force-pushed
the
task/2704-contactmoment-filter
branch
from
1379575
to
7cdc422
Compare
swrichards
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2704