[#2698] Remove default Django authentication backend #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the default Django auth backend is not compatible with our
practice of (a) using the email as username and (b) allowing
duplicate emails for DigiD users, because it checks for duplicate
usernames regardless of login type
- the overrides of the auth backends in the dev settings are
redundant (they don't change anything) and potentially confusing
(in case someone overrides them in base.py for local testing
purposes)
pi-sigma
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1368 +/- ##
========================================
Coverage 95.20% 95.20%
========================================
Files 1003 1003
Lines 37169 37169
========================================
Hits 35388 35388
Misses 1781 1781 ☔ View full report in Codecov by Sentry. |
|
@alextreme The PR assumes that we have no use case of DigiD/eHerkenning users attempting to log in with username + password. Can you confirm this? |
I certainly hope not. Hereby confirmed. |
swrichards
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2698